[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros
Date: Thu, 13 Jul 2017 20:35:05 +0300

On Thu, Jul 13, 2017 at 08:00:26PM +0800, gengdongjiu wrote:
>    Laszlo, I pasted Michael's comments here, as shown below. Michael said the 
> definition
> should use build_append_int_noprefix to add data. but I think it may not 
> good, becuase
> the section "UEFI_CPER_SEC_PLATFORM_MEM" is runtime recorded as CPER,

One thing I wanted to understand is how are races avoided. E.g. what if
you are in the process of writing out CPER and guest reads it.
I tried to find where is this function writing CPER called and couldn't.
Can you clarify pls?

> not a ACPI/HEST
> table member, so it is not generated when system boot up. On the other 
> definition is from UEFI spec 2.6, N.2.2 Section Descriptor: {0xA5BC1114, 
> 0x6F64, 0x4EDE, {0xB8, 0x63, 0x3E, 0x83, 0xED, 0x7C, 0x83, 0xB1}}.
> if use  build_append_int_noprefix to add, may confuse others.

Right but ACPI/HEST generation could use cleanup, and build_append_int_noprefix
would be a nice way to do it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]