[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/18] spapr: Abort on delete failure in spapr_drc_re
From: |
David Gibson |
Subject: |
[Qemu-devel] [PULL 06/18] spapr: Abort on delete failure in spapr_drc_release() |
Date: |
Fri, 14 Jul 2017 16:15:09 +1000 |
We currently ignore errors from the object_property_del() in
spapr_drc_release(). But the only way that could fail is if the property
doesn't exist, in which case it's a bug that we're in spapr_drc_release()
at all. So change from ignoring to abort()ing on errors.
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_drc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 89ba3d6b79..35b779451d 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -367,7 +367,7 @@ static void spapr_drc_release(sPAPRDRConnector *drc)
g_free(drc->fdt);
drc->fdt = NULL;
drc->fdt_start_offset = 0;
- object_property_del(OBJECT(drc), "device", NULL);
+ object_property_del(OBJECT(drc), "device", &error_abort);
drc->dev = NULL;
}
--
2.13.0
- [Qemu-devel] [PULL 00/18] ppc-for-2.10 queue 20170714, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 02/18] spapr: Minor cleanups to events handling, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 04/18] spapr: Remove 'awaiting_allocation' DRC flag, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 12/18] spapr: fix potential memory leak in spapr_core_plug(), David Gibson, 2017/07/14
- [Qemu-devel] [PULL 03/18] spapr: Treat devices added before inbound migration as coldplugged, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 01/18] spapr: migrate pending_events of spapr state, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 07/18] spapr: Refactor spapr_drc_detach(), David Gibson, 2017/07/14
- [Qemu-devel] [PULL 05/18] spapr: Simplify unplug path, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 13/18] ppc/pnv: Remove unused XICSState reference, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 06/18] spapr: Abort on delete failure in spapr_drc_release(),
David Gibson <=
- [Qemu-devel] [PULL 08/18] spapr: Cleanups relating to DRC awaiting_release field, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 18/18] pseries: Allow HPT resizing with KVM, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 10/18] spapr: Remove sPAPRConfigureConnectorState sub-structure, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 11/18] spapr: Implement DR-indicator for physical DRCs only, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 09/18] spapr: Consolidate DRC state variables, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 16/18] pseries: Enable HPT resizing for 2.10, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 17/18] pseries: Use smaller default hash page tables when guest can resize, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 14/18] pseries: Stubs for HPT resizing, David Gibson, 2017/07/14
- [Qemu-devel] [PULL 15/18] pseries: Implement HPT resizing, David Gibson, 2017/07/14
- Re: [Qemu-devel] [PULL 00/18] ppc-for-2.10 queue 20170714, Peter Maydell, 2017/07/14