[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device |
Date: |
Fri, 14 Jul 2017 23:17:48 +0300 |
On Fri, Jul 14, 2017 at 10:04:31PM +0200, Laszlo Ersek wrote:
> > It worries me that the format of this seems completely undefined
> > except in the patchset cover letter.
> > I don't think we should merge this before it is.
>
> I'm not sure what you mean, this patch adds "docs/specs/vmcoreinfo.txt".
> That file is the first level contract between the guest firmware
> (generally, via the linker/loader), the guest kernel driver
> (specifically), and QEMU (also specifically).
>
> The second level contract is the guest kernel's vmcoreinfo ELF note
> (which is pointed-to by the first level contract). The layout of that is
> specified elsewhere indeed (I don't think it belongs here).
>
> We've taken care not to trust anything coming from the guest kernel.
>
> Can you clarify please?
>
> Thanks
> Laszlo
All there is is this:
+Version 0 content:
+
+ uint64 paddr:
+ Physical address of the Linux vmcoreinfo ELF note.
+ uint32 size:
+ Size of the vmcoreinfo ELF note.
It isn't defined here what is the Linux vmcoreinfo ELF note.
You want a bit more info so people trying to use it know where to start
and what they can get out of it.
--
MST
- [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support, Marc-André Lureau, 2017/07/14
- [Qemu-devel] [PATCH v4 1/8] vmgenid: replace x-write-pointer-available hack, Marc-André Lureau, 2017/07/14
- [Qemu-devel] [PATCH v4 3/8] stubs: add vmcoreinfo_get() stub, Marc-André Lureau, 2017/07/14
- [Qemu-devel] [PATCH v4 4/8] tests: add simple vmcoreinfo test, Marc-André Lureau, 2017/07/14
- [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Marc-André Lureau, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Michael S. Tsirkin, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Laszlo Ersek, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Marc-André Lureau, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Michael S. Tsirkin, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Marc-André Lureau, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Michael S. Tsirkin, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Marc-André Lureau, 2017/07/14
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Michael S. Tsirkin, 2017/07/26
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Marc-André Lureau, 2017/07/28
- Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device, Laszlo Ersek, 2017/07/28
[Qemu-devel] [PATCH v4 5/8] dump: add vmcoreinfo ELF note, Marc-André Lureau, 2017/07/14
[Qemu-devel] [PATCH v4 6/8] kdump: add vmcoreinfo ELF note, Marc-André Lureau, 2017/07/14