[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/9] virtio-blk: use virtqueue_error for errors w
From: |
Ladi Prosek |
Subject: |
[Qemu-devel] [PATCH v3 5/9] virtio-blk: use virtqueue_error for errors with queue context |
Date: |
Mon, 17 Jul 2017 10:11:48 +0200 |
virtqueue_error includes the queue index in the error output and is preferred
for errors that pertain to a virtqueue rather than to the device as a whole.
Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
hw/block/virtio-blk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index b750bd8..359d8bd 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -490,20 +490,20 @@ static int virtio_blk_handle_request(VirtIOBlockReq *req,
MultiReqBuffer *mrb)
VirtIODevice *vdev = VIRTIO_DEVICE(s);
if (req->elem.out_num < 1 || req->elem.in_num < 1) {
- virtio_error(vdev, "virtio-blk missing headers");
+ virtqueue_error(req->vq, "virtio-blk missing headers");
return -1;
}
if (unlikely(iov_to_buf(iov, out_num, 0, &req->out,
sizeof(req->out)) != sizeof(req->out))) {
- virtio_error(vdev, "virtio-blk request outhdr too short");
+ virtqueue_error(req->vq, "virtio-blk request outhdr too short");
return -1;
}
iov_discard_front(&iov, &out_num, sizeof(req->out));
if (in_iov[in_num - 1].iov_len < sizeof(struct virtio_blk_inhdr)) {
- virtio_error(vdev, "virtio-blk request inhdr too short");
+ virtqueue_error(req->vq, "virtio-blk request inhdr too short");
return -1;
}
--
2.9.3
- [Qemu-devel] [PATCH v3 0/9] virtio: enhance virtio_error messages, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 2/9] virtio: introduce virtqueue_error, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 1/9] virtio: enhance virtio_error messages, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 3/9] virtio: use virtqueue_error for errors with queue context, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 5/9] virtio-blk: use virtqueue_error for errors with queue context,
Ladi Prosek <=
- [Qemu-devel] [PATCH v3 4/9] virtio-9p: use virtqueue_error for errors with queue context, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 6/9] virtio-net: use virtqueue_error for errors with queue context, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 7/9] virtio-scsi: use virtqueue_error for errors with queue context, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 8/9] virtio-crypto: use virtqueue_error for errors with queue context, Ladi Prosek, 2017/07/17
- [Qemu-devel] [PATCH v3 9/9] checkpatch: add virtio_error and virtqueue_error to error funcs, Ladi Prosek, 2017/07/17