[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_ge
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init() |
Date: |
Mon, 17 Jul 2017 17:05:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Am 17.07.2017 um 12:41 schrieb Igor Mammedov:
> On Sat, 15 Jul 2017 08:08:58 -1000
> Richard Henderson <address@hidden> wrote:
>
>> On 07/14/2017 03:52 AM, Igor Mammedov wrote:
>>> @@ -230,6 +230,8 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error
>>> **errp)
>>> M68kCPUClass *mcc = M68K_CPU_GET_CLASS(dev);
>>> Error *local_err = NULL;
>>>
>>> + register_m68k_insns(&cpu->env);
>>> +
>>
>> I think it would make more sense to do this during m68k_tcg_init.
>>
> it seems that m68k_cpu_initfn accesses 'env' via some global,
> while cpu_mk68k_init() used to access concrete pointer of just created cpu,
>
> how about moving register_m68k_insns() to m68k_cpu_initfn(), instead?
> it should be equivalent to what cpu_mk68k_init() used to do.
As a general note, realize should be re-entrant. Can't tell from the
above diff whether that is the case here.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init(), (continued)
[Qemu-devel] [PATCH 16/28] nios2: replace cpu_nios2_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 15/28] microblaze: replace cpu_mb_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 17/28] tilegx: replace cpu_tilegx_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 18/28] xtensa: replace cpu_xtensa_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 20/28] sh4: replace cpu_sh4_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 19/28] tricore: replace cpu_tricore_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 22/28] cris: replace cpu_cris_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14