Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

[Daniel P. Berrange]

On Tue, Jul 18, 2017 at 10:37:30AM +0100, Peter Maydell wrote:
> On 18 July 2017 at 10:11, Thomas Huth <address@hidden> wrote:
> > Could the test be rewritten to provide a proper timeout handling
> > instead? Tests should clearly fail after a while instead of hanging
> > forever...
> > Or maybe we could add some magic that the troublesome tests are not
> > executed if a certain environment variable is set, so we could skip them
> > in these automated setups here?
> 
> I think it's always going to be possible that some bug in
> QEMU results in a test hanging -- so it must be down to
> the test harness to deal with hanging tests. And then
> once you have that functionality in the test harness it
> doesn't matter quite so much whether an individual test
> has its own timeout handling or not.

If the tests are all inside a docker container, then dealing with a hanging
test is no more difficult than waiting a suitable amount of time and then
telling docker to destroy the container.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|