Re: [Qemu-devel] [PULL 32/40] s390x/cpumodel: add zpci, aen and ais facilities

[David Hildenbrand]

On 17.07.2017 20:12, Christian Borntraeger wrote:
> On 07/17/2017 07:23 PM, David Hildenbrand wrote:
>>
>>> +    /* Try to enable AIS facility */
>>> +    kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0);
>>> +
>>>      qemu_mutex_init(&qemu_sigp_mutex);
>>>  
>>>      return 0;
>>> @@ -2635,6 +2638,10 @@ void kvm_s390_get_host_cpu_model(S390CPUModel 
>>> *model, Error **errp)
>>>          set_bit(S390_FEAT_CMM, model->features);
>>>      }
>>>  
>>> +    /* set zpci and aen facilities */
>>
>> This comment is not helpful. This should rather say something like "we
>> emulate a zPCI bus in QEMU, therefore we don't depend on the host
>> capabilities"
> 
> Yes, you are right, that seems better. Can you send a patch? 

Yes, will do.

-- 

Thanks,

David