Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type

[Eric Blake]

On 07/18/2017 02:43 PM, Markus Armbruster wrote:
> Markus Armbruster <address@hidden> writes:
> 
>> Eric Blake <address@hidden> writes:
>>
>>> On 07/18/2017 09:53 AM, Eric Blake wrote:
>>>> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>>>>> I expect the 'null' type to be useful mostly for members of alternate
>>>>> types.
>>>>>
>>>>> Signed-off-by: Markus Armbruster <address@hidden>
>>>>> ---
>>>>
>>>
>>>> Reviewed-by: Eric Blake <address@hidden>
>>>
>>> Actually, do we need to update any qapi docs to mention the new builtin
>>> type?
>>
>> Yes, we do.  I'll give it a shot.
> 
> Incremental patch appended.  May I keep your R-by?
> 
> 
> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
> index 52e3874..6d8e00c 100644
> --- a/docs/devel/qapi-code-gen.txt
> +++ b/docs/devel/qapi-code-gen.txt
> @@ -283,6 +283,7 @@ The following types are predefined, and map to C as 
> follows:
>                         accepts size suffixes
>    bool      bool       JSON true or false
>    any       QObject *  any JSON value
> +  null      QNull *    JSON null
>    QType     QType      JSON string matching enum QType values

I might have grouped 'null' next to 'bool', but your layout is also
okay.  Yes, my R-b is still valid with this addition.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature