Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
fcb0d9f net/colo-compare.c: Fix comments and scheme
1b4531a net/colo-compare.c: Adjust net queue pop order for performance
8433e86 net/colo-compare.c: Optimize unpredictable tcp options comparison
384fa35 net/colo-compare.c: Add checkpoint min period to optimize performance

=== OUTPUT BEGIN ===
Checking PATCH 1/4: net/colo-compare.c: Add checkpoint min period to optimize 
performance...
Checking PATCH 2/4: net/colo-compare.c: Optimize unpredictable tcp options 
comparison...
Checking PATCH 3/4: net/colo-compare.c: Adjust net queue pop order for 
performance...
Checking PATCH 4/4: net/colo-compare.c: Fix comments and scheme...
ERROR: spaces required around that '|' (ctx:ExV)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
   ^

ERROR: spaces required around that '+' (ctx:WxO)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                   ^

ERROR: spaces required around that '+' (ctx:WxO)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                                       ^

ERROR: spaces required around that '|' (ctx:WxO)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                                                                 ^

ERROR: spaces prohibited around that '->' (ctx:OxW)
#18: FILE: net/colo-compare.c:50:
+  |conn list      +--->conn           +--------->conn           |---> .......
                                                                    ^

total: 5 errors, 0 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden