Re: [Qemu-devel] [PATCH] dvs services stop then qemu may be accesse null address case core

[indiffpig]

No one replied to my mail. Someone might think I was talking nonsense. When the 
DVS service stopped, all our QEMU processes exited. DVS users complain that 
even if their DVS services are stopped, vhost-user networks should not be 
blocked, but virtual machines should not be allowed to exit. I found the 
segdefault error in the host's log about QEMU, and all errors are pointing to 
the null pointer referred to in the patch. What does open source maintenance 
staff think about?







At 2017-07-14 19:27:57, address@hidden wrote:
>From: "yin.zuowei" <address@hidden>
>
>Signed-off-by: yin.zuowei <address@hidden>
>---
> chardev/char-fe.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/chardev/char-fe.c b/chardev/char-fe.c
>index 3f90f05..82f7e2b 100644
>--- a/chardev/char-fe.c
>+++ b/chardev/char-fe.c
>@@ -353,7 +353,13 @@ guint qemu_chr_fe_add_watch(CharBackend *be, GIOCondition 
>cond,
> 
> void qemu_chr_fe_disconnect(CharBackend *be)
> {
>-    Chardev *chr = be->chr;
>+    Chardev *chr = NULL;
>+
>+    if (be) {
>+        chr = be->chr;
>+    } else {
>+        return ;
>+    }
> 
>     if (chr && CHARDEV_GET_CLASS(chr)->chr_disconnect) {
>         CHARDEV_GET_CLASS(chr)->chr_disconnect(chr);
>-- 
>1.8.3.1
>