Re: [Qemu-devel] [PATCH 0/5] target/s390x: Fix broken build with --disable-tcg

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/5] target/s390x: Fix broken build with 
--disable-tcg
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
93bc72a target/s390x: Add remaining switches to compile with --disable-tcg
7ed9f55 target/s390x: Move exception-related functions to a new excp_helper.c 
file
1285eb9 target/s390x: Move diag helpers to a separate file
26943a8 target/s390x: Move s390_cpu_dump_state() to helper.c
87577ec target/s390x: Move program_interrupt() & trigger_pgm_exception() to 
interrupt.c

=== OUTPUT BEGIN ===
Checking PATCH 1/5: target/s390x: Move program_interrupt() & 
trigger_pgm_exception() to interrupt.c...
Checking PATCH 2/5: target/s390x: Move s390_cpu_dump_state() to helper.c...
Checking PATCH 3/5: target/s390x: Move diag helpers to a separate file...
Checking PATCH 4/5: target/s390x: Move exception-related functions to a new 
excp_helper.c file...
ERROR: do not use C99 // comments
#98: FILE: target/s390x/excp_helper.c:32:
+//#define DEBUG_S390

ERROR: do not use C99 // comments
#99: FILE: target/s390x/excp_helper.c:33:
+//#define DEBUG_S390_STDOUT

ERROR: braces {} are necessary for all arms of this statement
#105: FILE: target/s390x/excp_helper.c:39:
+         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
[...]

total: 3 errors, 0 warnings, 1062 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: target/s390x: Add remaining switches to compile with 
--disable-tcg...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden