|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v3 43/43] tcg: enable multiple TCG contexts in softmmu |
Date: | Wed, 19 Jul 2017 22:17:53 -1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/19/2017 05:09 PM, Emilio G. Cota wrote:
+#ifdef CONFIG_SOFTMMU +/* + * It is likely that some vCPUs will translate more code than others, so we + * first try to set more regions than smp_cpus, with those regions being of + * reasonable size. If that's not possible we make do by evenly dividing + * the code_gen_buffer among the vCPUs. + */ +static size_t tcg_n_regions(void)
Use #ifdef CONFIG_USER_ONLY here.In the back of your mind, please remove the SOFTMMU == !USER_ONLY equality that tends to pervade the code base at present.
At some point in the (distant) future I want to be able to enable SOFTMMU for USER_ONLY. There is *lots* that doesn't work when the host page size != guest page size. Which is becoming more and more common (on non-x86) as enterprise operating systems enable 64k pages.
Otherwise, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |