Re: [Qemu-devel] Build failure on git master

[Mark Cave-Ayland]

On 20/07/17 22:09, Peter Maydell wrote:

>> The fix is seemingly quite simple:
>>
>> diff --git a/block/vpc.c b/block/vpc.c
>> index 10e6519..574879b 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -649,7 +649,7 @@ vpc_co_pwritev(BlockDriverState *bs, uint64_t
>> offset, uint64_t bytes,
>>      int64_t image_offset;
>>      int64_t n_bytes;
>>      int64_t bytes_done = 0;
>> -    int ret;
>> +    int ret = 0;
>>      VHDFooter *footer =  (VHDFooter *) s->footer_buf;
> 
> Yeah, I think 4.7.2 isn't smart enough to realize this is
> a false positive (and that compiler is getting old enough
> that it's not in the set I usually test with).
> 
> Do you want to send a proper patch?

Done. Hopefully one of these days I'll be able to figure out how to
migrate everything on the laptop across to something a bit more modern...


ATB,

Mark.