Re: [Qemu-devel] [PATCH v14 26/34] target/arm: [tcg] Port to tb_stop

[Emilio G. Cota]

On Fri, Jul 14, 2017 at 23:42:35 -1000, Richard Henderson wrote:
> From: Lluís Vilanova <address@hidden>
> 
> Incrementally paves the way towards using the generic instruction translation
> loop.
> 
> Signed-off-by: Lluís Vilanova <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
(snip)
> @@ -12135,6 +12063,7 @@ void gen_intermediate_code(CPUState *cs, 
> TranslationBlock *tb)
>          default:
>              /* FIXME: Single stepping a WFI insn will not halt the CPU. */
>              gen_singlestep_exception(dc);
> +            break;
>          case DISAS_NORETURN:
>              break;
>          }

See my comment to patch 4.

Otherwise,
Reviewed-by: Emilio G. Cota <address@hidden>

                E.