[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 01/17] migrate: Add gboolean return type to m
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v5 01/17] migrate: Add gboolean return type to migrate_channel_process_incoming |
Date: |
Mon, 24 Jul 2017 12:18:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Daniel P. Berrange" <address@hidden> wrote:
> On Thu, Jul 20, 2017 at 03:00:23PM +0800, Peter Xu wrote:
>> On Wed, Jul 19, 2017 at 04:01:10PM +0100, Dr. David Alan Gilbert wrote:
>> > * Juan Quintela (address@hidden) wrote:
>> > >
>> > > -void migration_channel_process_incoming(QIOChannel *ioc);
>> > > +gboolean migration_channel_process_incoming(QIOChannel *ioc);
>> >
>> > Can you add a comment here that says what the return value means.
Added comment for the two functions (in the .c file through)
>>
>> And, looks like we have G_SOURCE_CONTINUE and G_SOURCE_REMOVE:
Used this ones, thanks.
>> https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html#G-SOURCE-CONTINUE:CAPS
>>
>> Maybe we can use them as well?
>
> Those are newer than our min required glib version, though we could
> add compat defines for them
Added the compatibility macros.
Thanks to all of you, Juan.
[Qemu-devel] [PATCH v5 03/17] qio: Create new qio_channel_{readv, writev}_all, Juan Quintela, 2017/07/17
[Qemu-devel] [PATCH v5 04/17] migration: Add multifd capability, Juan Quintela, 2017/07/17
[Qemu-devel] [PATCH v5 05/17] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/07/17