Re: [Qemu-devel] [PATCH v2] hmp/(p)memsave: Allow >32bit file size

[Markus Armbruster]

"Dr. David Alan Gilbert (git)" <address@hidden> writes:

> From: "Dr. David Alan Gilbert" <address@hidden>
>
> memsave and pmemsave only take 32bit size arguments in HMP at the
> moment; let them take 64bit values.
>
> Reported-by: Pierre Kim <address@hidden>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hmp-commands.hx |  4 ++--
>  hmp.c           | 13 +++++++++++--
>  2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 1941e19932..ddf77ae7ac 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -829,7 +829,7 @@ ETEXI
>  
>      {
>          .name       = "memsave",
> -        .args_type  = "val:l,size:i,filename:s",
> +        .args_type  = "val:l,size:l,filename:s",
>          .params     = "addr size file",
>          .help       = "save to disk virtual memory dump starting at 'addr' 
> of size 'size'",
>          .cmd        = hmp_memsave,

The size is wider, but still signed.  Reproduces QAPI/QMP's mistake.  We
should fix it there, and make this "size:o" here, so suffixes work as
they should.

I'll cook up a QAPI/QMP patch.

[...]