[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] cpu_physical_memory_sync_dirty_bitmap: Fix a
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check |
|
Date: |
Tue, 25 Jul 2017 23:07:13 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: Dr. David Alan Gilbert <address@hidden>
>
> This code has an optimised, word aligned version, and a boring
> unaligned version. Recently 084140bd498909 fixed a missing offset
> addition from the core of both versions. However, the offset isn't
> necessarily aligned and thus the choice between the two versions
> needs fixing up to also include the offset.
>
> Symptom:
> A few stuck unsent pages during migration; not normally noticed
> unless under very low bandwidth in which case the migration may get
> stuck never ending and never performing a 2nd sync; noticed by
> a hanging postcopy-test on a very heavily loaded system.
>
> Fixes: 084140bd498909
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reported-by: Alex Benneé <address@hidden>
> Tested-by: Alex Benneé <address@hidden>
>
Reviewed-by: Juan Quintela <address@hidden>