Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

[Yongbok Kim]

On 26/07/2017 05:13, Philippe Mathieu-Daudé wrote:
> Hi John,
> 
> On 07/25/2017 07:55 PM, Programmingkid wrote:
>> While compiling the mips64el-softmmu target I encountered these errors:
>>
>>    CC      hw/display/g364fb.o
>> hw/core/loader-fit.c:105:41: error: expected expression
>>          *addr = fdt32_to_cpu(*(fdt32_t *)prop);
>>                                          ^
>> hw/core/loader-fit.c:105:32: error: use of undeclared identifier 'fdt32_t'
> 
> It seems you are missing the libfdt headers, so indeed you found bug.
> 
> Replacing CONFIG_FITLOADER by CONFIG_FDT in hw/core/Makefile.objs and
> default-configs/mips64el-softmmu.mak should fix it, can you try?
> 
>>          *addr = fdt32_to_cpu(*(fdt32_t *)prop);
>>                                 ^
>> hw/core/loader-fit.c:108:41: error: expected expression
>>          *addr = fdt64_to_cpu(*(fdt64_t *)prop);
>>                                          ^
>> hw/core/loader-fit.c:108:32: error: use of undeclared identifier 'fdt64_t'
>>          *addr = fdt64_to_cpu(*(fdt64_t *)prop);
>>                                 ^
>> hw/core/loader-fit.c:278:19: warning: implicit declaration of function
>>        'fdt_first_subnode' is invalid in C99
>> [-Wimplicit-function-declaration]
>>              off = fdt_first_subnode(itb, configs);
>>                    ^
>> hw/core/loader-fit.c:286:23: warning: implicit declaration of function
>>        'fdt_next_subnode' is invalid in C99
>> [-Wimplicit-function-declaration]
>>                  off = fdt_next_subnode(itb, off);
>>                        ^
>> 2 warnings and 4 errors generated.
>> make: *** [hw/core/loader-fit.o] Error 1
>> make: *** Waiting for unfinished jobs….
> 
> It'd be useful if next time you also tell which compiler/version are you
> using.
> 
>> Steps to reproduce the error:
>> ./configure --target-list=mips64el-softmmu && make
> 
> And also the ./configure output, I'm interested by:
> 
> "fdt support       no"
> 
> Regards,
> 
> Phil.



Hi,

As Philippe pointed, it looks like something with dtc(libfdt).
Could you also try to install DTC into your QEMU source base?
By default for mips64el-softmmu, if DTC is not compatible you should get
this message.

ERROR: DTC (libfdt) version >= 1.4.2 not present. Your options:
         (1) Preferred: Install the DTC (libfdt) devel package
         (2) Fetch the DTC submodule, using:
             git submodule update --init dtc

Since I am not able to reproduce the problem on my machines,
please let us know the detail of your system.

$ ../master/configure --target-list=mips64el-softmmu && make -j
...
  GEN     trace/generated-helpers.c
  CC      mips64el-softmmu/trace/control-target.o
  CC      mips64el-softmmu/trace/generated-helpers.o
  LINK    mips64el-softmmu/qemu-system-mips64el

Regards,
Yongbok