[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] cpu: cpu_by_arch_id() helper
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH] cpu: cpu_by_arch_id() helper |
Date: |
Wed, 26 Jul 2017 15:53:05 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
The helper can be used for CPU object lookup using the CPU's
arch-specific ID (the one returned by CPUClass::get_arch_id()).
Signed-off-by: Eduardo Habkost <address@hidden>
[Yi Wang: Added documentation comments]
Signed-off-by: Yi Wang <address@hidden>
Signed-off-by: Yun Liu <address@hidden>
[ehabkost: extracted cpu_by_arch_id() to a separate patch]
Signed-off-by: Eduardo Habkost <address@hidden>
---
On Wed, Jul 26, 2017 at 02:36:38PM -0300, Eduardo Habkost wrote:
> I suggest sending cpu_by_arch_id() in a separate patch, to let
> maintainers cherry-pick and revert individual patches more
> easily. But there's no need to send v3 just because of that, I
> can split it while committing.
This is the patch I am queueing for 2.11 on my x86-next branch.
---
include/qom/cpu.h | 10 ++++++++++
qom/cpu.c | 11 ++++++++---
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 25eefea..b7ac949 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -755,6 +755,16 @@ CPUState *qemu_get_cpu(int index);
bool cpu_exists(int64_t id);
/**
+ * cpu_by_arch_id:
+ * @id: Guest-exposed CPU ID of the CPU to obtain.
+ *
+ * Get a CPU with matching @id.
+ *
+ * Returns: The CPU or %NULL if there is no matching CPU.
+ */
+CPUState *cpu_by_arch_id(int64_t id);
+
+/**
* cpu_throttle_set:
* @new_throttle_pct: Percent of sleep time. Valid range is 1 to 99.
*
diff --git a/qom/cpu.c b/qom/cpu.c
index 4f38db0..e6210d5 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -34,7 +34,7 @@
CPUInterruptHandler cpu_interrupt_handler;
-bool cpu_exists(int64_t id)
+CPUState *cpu_by_arch_id(int64_t id)
{
CPUState *cpu;
@@ -42,10 +42,15 @@ bool cpu_exists(int64_t id)
CPUClass *cc = CPU_GET_CLASS(cpu);
if (cc->get_arch_id(cpu) == id) {
- return true;
+ return cpu;
}
}
- return false;
+ return NULL;
+}
+
+bool cpu_exists(int64_t id)
+{
+ return !!cpu_by_arch_id(id);
}
CPUState *cpu_generic_init(const char *typename, const char *cpu_model)
--
2.9.4
- [Qemu-devel] [PATCH v2 0/2] hmp: support querying lapic through apic-id for 'info lapic', Yi Wang, 2017/07/26
- [Qemu-devel] [PATCH v2 2/2] hmp: allow apic-id for "info lapic", Yi Wang, 2017/07/26
- [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Yi Wang, 2017/07/26
- Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Eduardo Habkost, 2017/07/26
- Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Igor Mammedov, 2017/07/26
- Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Eduardo Habkost, 2017/07/26
- Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Igor Mammedov, 2017/07/27
- Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Eduardo Habkost, 2017/07/27
Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers', Igor Mammedov, 2017/07/26
Re: [Qemu-devel] [PATCH v2 0/2] hmp: support querying lapic through apic-id for 'info lapic', no-reply, 2017/07/26