Re: [Qemu-devel] [PATCH for 2.10 0/4] check dtc submodule is outdated

[Philippe Mathieu-Daudé]

On 07/26/2017 06:40 PM, Philippe Mathieu-Daudé wrote:> patch 4: if no 
system libdtc and submodule present, compile the dtc submodule
> and verify it is at least v1.4.2. Prefixed RFC because I'm not sure about
> these 3 lines:
>
> +    make -C dtc 1>/dev/null

which can leads to:

/bin/sh: 1: cannot create libfdt/fdt_sw.d: Read-only file system
         DEP libfdt/fdt_wip.c

so the libdtc build should be handle more seriously :(

> yes, we need to build the libdtc to be able to run the compile_prog link step
>
> +    fdt_cflags="-I${source_path}/dtc/libfdt"
>
> $source_path seems ok...
>
> +    fdt_libs="-L$(pwd)/dtc/libfdt $fdt_libs"
>
> maybe there is a better option than `pwd`