Re: [Qemu-devel] [PATCH] multiboot: Change multiboot_info from array of bytes to a C struct

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH] multiboot: Change multiboot_info from array of 
bytes to a C struct
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
202968a multiboot: Change multiboot_info from array of bytes to a C struct

=== OUTPUT BEGIN ===
Checking PATCH 1/1: multiboot: Change multiboot_info from array of bytes to a C 
struct...
WARNING: line over 80 characters
#77: FILE: hw/i386/multiboot.c:105:
+    mod = s->mb_buf + s->offset_mbinfo + sizeof(multiboot_module_t) * 
s->mb_mods_count;

ERROR: line over 90 characters
#193: FILE: hw/i386/multiboot.c:260:
+    mbs.offset_cmdlines   = mbs.offset_mbinfo + mbs.mb_mods_avail * 
sizeof(multiboot_module_t);

WARNING: line over 80 characters
#263: FILE: hw/i386/multiboot_header.h:17:
+ *  DEVELOPER OR DISTRIBUTOR BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 
LIABILITY,

WARNING: line over 80 characters
#265: FILE: hw/i386/multiboot_header.h:19:
+ *  IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 
SOFTWARE.

ERROR: code indent should never use tabs
#272: FILE: hw/i386/multiboot_header.h:26:
+#define MULTIBOOT_SEARCH^I^I^I8192$

ERROR: code indent should never use tabs
#273: FILE: hw/i386/multiboot_header.h:27:
+#define MULTIBOOT_HEADER_ALIGN^I^I^I4$

ERROR: code indent should never use tabs
#276: FILE: hw/i386/multiboot_header.h:30:
+#define MULTIBOOT_HEADER_MAGIC^I^I^I0x1BADB002$

ERROR: code indent should never use tabs
#279: FILE: hw/i386/multiboot_header.h:33:
+#define MULTIBOOT_BOOTLOADER_MAGIC^I^I0x2BADB002$

ERROR: code indent should never use tabs
#282: FILE: hw/i386/multiboot_header.h:36:
+#define MULTIBOOT_MOD_ALIGN^I^I^I0x00001000$

ERROR: code indent should never use tabs
#285: FILE: hw/i386/multiboot_header.h:39:
+#define MULTIBOOT_INFO_ALIGN^I^I^I0x00000004$

ERROR: code indent should never use tabs
#290: FILE: hw/i386/multiboot_header.h:44:
+#define MULTIBOOT_PAGE_ALIGN^I^I^I0x00000001$

ERROR: code indent should never use tabs
#293: FILE: hw/i386/multiboot_header.h:47:
+#define MULTIBOOT_MEMORY_INFO^I^I^I0x00000002$

ERROR: code indent should never use tabs
#296: FILE: hw/i386/multiboot_header.h:50:
+#define MULTIBOOT_VIDEO_MODE^I^I^I0x00000004$

ERROR: code indent should never use tabs
#299: FILE: hw/i386/multiboot_header.h:53:
+#define MULTIBOOT_AOUT_KLUDGE^I^I^I0x00010000$

ERROR: code indent should never use tabs
#304: FILE: hw/i386/multiboot_header.h:58:
+#define MULTIBOOT_INFO_MEMORY^I^I^I0x00000001$

ERROR: code indent should never use tabs
#306: FILE: hw/i386/multiboot_header.h:60:
+#define MULTIBOOT_INFO_BOOTDEV^I^I^I0x00000002$

ERROR: code indent should never use tabs
#308: FILE: hw/i386/multiboot_header.h:62:
+#define MULTIBOOT_INFO_CMDLINE^I^I^I0x00000004$

ERROR: code indent should never use tabs
#310: FILE: hw/i386/multiboot_header.h:64:
+#define MULTIBOOT_INFO_MODS^I^I^I0x00000008$

ERROR: code indent should never use tabs
#315: FILE: hw/i386/multiboot_header.h:69:
+#define MULTIBOOT_INFO_AOUT_SYMS^I^I0x00000010$

ERROR: code indent should never use tabs
#317: FILE: hw/i386/multiboot_header.h:71:
+#define MULTIBOOT_INFO_ELF_SHDR^I^I^I0X00000020$

ERROR: code indent should never use tabs
#320: FILE: hw/i386/multiboot_header.h:74:
+#define MULTIBOOT_INFO_MEM_MAP^I^I^I0x00000040$

ERROR: code indent should never use tabs
#323: FILE: hw/i386/multiboot_header.h:77:
+#define MULTIBOOT_INFO_DRIVE_INFO^I^I0x00000080$

ERROR: code indent should never use tabs
#326: FILE: hw/i386/multiboot_header.h:80:
+#define MULTIBOOT_INFO_CONFIG_TABLE^I^I0x00000100$

ERROR: code indent should never use tabs
#329: FILE: hw/i386/multiboot_header.h:83:
+#define MULTIBOOT_INFO_BOOT_LOADER_NAME^I^I0x00000200$

ERROR: code indent should never use tabs
#332: FILE: hw/i386/multiboot_header.h:86:
+#define MULTIBOOT_INFO_APM_TABLE^I^I0x00000400$

ERROR: code indent should never use tabs
#335: FILE: hw/i386/multiboot_header.h:89:
+#define MULTIBOOT_INFO_VBE_INFO^I^I        0x00000800$

ERROR: code indent should never use tabs
#336: FILE: hw/i386/multiboot_header.h:90:
+#define MULTIBOOT_INFO_FRAMEBUFFER_INFO^I        0x00001000$

ERROR: open brace '{' following struct go on the same line
#339: FILE: hw/i386/multiboot_header.h:93:
+struct multiboot_header
+{

ERROR: open brace '{' following struct go on the same line
#365: FILE: hw/i386/multiboot_header.h:119:
+struct multiboot_aout_symbol_table
+{

ERROR: open brace '{' following struct go on the same line
#375: FILE: hw/i386/multiboot_header.h:129:
+struct multiboot_elf_section_header_table
+{

WARNING: line over 80 characters
#381: FILE: hw/i386/multiboot_header.h:135:
+typedef struct multiboot_elf_section_header_table 
multiboot_elf_section_header_table_t;

ERROR: open brace '{' following struct go on the same line
#384: FILE: hw/i386/multiboot_header.h:138:
+struct multiboot_info
+{

ERROR: open brace '{' following union go on the same line
#403: FILE: hw/i386/multiboot_header.h:157:
+  union
+  {

ERROR: code indent should never use tabs
#440: FILE: hw/i386/multiboot_header.h:194:
+#define MULTIBOOT_FRAMEBUFFER_TYPE_EGA_TEXT^I2$

ERROR: open brace '{' following union go on the same line
#443: FILE: hw/i386/multiboot_header.h:197:
+  union
+  {

ERROR: open brace '{' following struct go on the same line
#445: FILE: hw/i386/multiboot_header.h:199:
+    struct
+    {

ERROR: open brace '{' following struct go on the same line
#450: FILE: hw/i386/multiboot_header.h:204:
+    struct
+    {

ERROR: open brace '{' following struct go on the same line
#463: FILE: hw/i386/multiboot_header.h:217:
+struct multiboot_color
+{

ERROR: open brace '{' following struct go on the same line
#470: FILE: hw/i386/multiboot_header.h:224:
+struct multiboot_mmap_entry
+{

ERROR: code indent should never use tabs
#474: FILE: hw/i386/multiboot_header.h:228:
+#define MULTIBOOT_MEMORY_AVAILABLE^I^I1$

ERROR: code indent should never use tabs
#475: FILE: hw/i386/multiboot_header.h:229:
+#define MULTIBOOT_MEMORY_RESERVED^I^I2$

ERROR: open brace '{' following struct go on the same line
#484: FILE: hw/i386/multiboot_header.h:238:
+struct multiboot_mod_list
+{

ERROR: open brace '{' following struct go on the same line
#499: FILE: hw/i386/multiboot_header.h:253:
+struct multiboot_apm_info
+{

ERROR: Missing Signed-off-by: line(s)

total: 40 errors, 4 warnings, 479 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden