[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers |
|
Date: |
Fri, 28 Jul 2017 13:30:35 +0200 |
On Fri, 28 Jul 2017 13:01:15 +0300
Vladimir Sementsov-Ogievskiy <address@hidden> wrote:
> 28.07.2017 12:41, Cornelia Huck wrote:
> > On Fri, 28 Jul 2017 11:55:47 +0300
> > Vladimir Sementsov-Ogievskiy <address@hidden> wrote:
> >
> >> To make logs more readable prefix all hex values with '0x' mark.
> >> This is needed for consistency too, as a lot of hex values are already
> >> prefixed with '0x'. Also, bring all hex outputs to the common form -
> >> use '%#', not '0x%'.
> > This is problematic if you try to match up things in the trace with
> > things that don't have the leading 0x elsewhere. See my comments on the
> > s390x changes below.
>
> Hmm, not so easy..
>
> All your remarks satisfy the following criteria (and it seems logical
> anyway):
>
> hex numbers grouped into patterns like NUM.NUM.NUM (several numbers
> splitted by period) are allowed to be printed without 0x prefixes.
Works for me. There might be other similar patterns, though.