Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Eric Blake]

On 07/28/2017 11:26 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <address@hidden> writes:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---

>> +# This script checks MAINTAINERS consistency
> 
> Consistency?  I think you mean coverage.

Indeed - consistency implies even more, such as all email addresses and
git trees are still valid.  Coverage is merely that all files at least
have one listed owner, whether or not that owner is still correct.

> But what I really want is checkpatch whining when it happens.  Thomas
> posted a patch some time ago.  Would you be willing to revive it?
> 
> https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05742.html
> Message-Id: <address@hidden>
> 
> Basically:
> 
> * Patch deletes a file
> 
>   - still in MAINTAINERS after the patch: warn
>   - else: ok
> 

Careful, since we have globs in MAINTAINERS.  I guess it really means:

* Patch deletes a file:
   - check all lines in MAINTAINERS; if any no longer maps to a file: warn
   - else: ok

> * Patch creates a file
> 
>   - not in in MAINTAINERS after the patch: warn
>   - else: ok
> 
> * Patch moves a file

Same as delete + move, even if it shows up in git differently.

> 
> May have to ignore "uninteresting" files to reduce the noise.  But even
> ignoring everything but *.[ch] would be an improvement!

And like all checkpatch warnings, maintainers (or, in this case, lack of
maintainer?) can ignore the warning and submit pull request anyway.  But
the key part is that by making it part of checkpatch, coupled with
patchew CI, the whole list would know who's ignoring the warnings :)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature