[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scrat
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scratch images |
Date: |
Fri, 28 Jul 2017 17:34:13 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jul 28, 2017 at 03:14:46PM +0200, Kevin Wolf wrote:
> qemu-iotests 041 left quorum_snapshot.img and target.img behind in the
> scratch directory. Make sure to clean up after completing the tests.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/041 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index 4cda540735..a860a31e9a 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -418,6 +418,7 @@ new_state = "1"
> def tearDown(self):
> self.vm.shutdown()
> os.remove(test_img)
> + os.remove(target_img)
> os.remove(backing_img)
> os.remove(self.blkdebug_file)
>
> @@ -568,6 +569,7 @@ new_state = "1"
> def tearDown(self):
> self.vm.shutdown()
> os.remove(test_img)
> + os.remove(target_img)
> os.remove(backing_img)
> os.remove(self.blkdebug_file)
>
> @@ -821,7 +823,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
>
> def tearDown(self):
> self.vm.shutdown()
> - for i in self.IMAGES + [ quorum_repair_img ]:
> + for i in self.IMAGES + [ quorum_repair_img, quorum_snapshot_file ]:
> # Do a try/except because the test may have deleted some images
> try:
> os.remove(i)
> --
> 2.13.3
>
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-devel] [PATCH for-2.10 0/7] qemu-iotests: Fix leaked temporary file fixes, Kevin Wolf, 2017/07/28
- [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scratch images, Kevin Wolf, 2017/07/28
- [Qemu-devel] [PATCH for-2.10 3/7] qemu-iotests/141: Fix image cleanup, Kevin Wolf, 2017/07/28
- [Qemu-devel] [PATCH for-2.10 2/7] qemu-iotests: Remove blkdebug.conf after tests, Kevin Wolf, 2017/07/28
- [Qemu-devel] [PATCH for-2.10 4/7] qemu-iotests/153: Fix leaked scratch images, Kevin Wolf, 2017/07/28
- [Qemu-devel] [PATCH for-2.10 5/7] qemu-iotests/162: Fix leaked temporary files, Kevin Wolf, 2017/07/28
- [Qemu-devel] [PATCH for-2.10 6/7] qemu-iotests/063: Fix leaked image, Kevin Wolf, 2017/07/28