[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 17/25] syscall: check inotify() and eventfd() return
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 17/25] syscall: check inotify() and eventfd() return value |
Date: |
Mon, 31 Jul 2017 13:21:36 +0300 |
From: Philippe Mathieu-Daudé <address@hidden>
linux-user/syscall.c:555:25: warning: Out of bound memory access (accessed
memory precedes memory block)
target_fd_trans[fd] = trans;
~~~~~~~~~~~~~~~~~~~~^~~~~~~
Reported-by: Clang Static Analyzer
Suggested-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
linux-user/syscall.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 81f52f7483..dfc1301e63 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11742,7 +11742,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
#if defined(TARGET_NR_inotify_init) && defined(__NR_inotify_init)
case TARGET_NR_inotify_init:
ret = get_errno(sys_inotify_init());
- fd_trans_register(ret, &target_inotify_trans);
+ if (ret >= 0) {
+ fd_trans_register(ret, &target_inotify_trans);
+ }
break;
#endif
#ifdef CONFIG_INOTIFY1
@@ -11750,7 +11752,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
case TARGET_NR_inotify_init1:
ret = get_errno(sys_inotify_init1(target_to_host_bitmask(arg1,
fcntl_flags_tbl)));
- fd_trans_register(ret, &target_inotify_trans);
+ if (ret >= 0) {
+ fd_trans_register(ret, &target_inotify_trans);
+ }
break;
#endif
#endif
@@ -11916,7 +11920,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
#if defined(TARGET_NR_eventfd)
case TARGET_NR_eventfd:
ret = get_errno(eventfd(arg1, 0));
- fd_trans_register(ret, &target_eventfd_trans);
+ if (ret >= 0) {
+ fd_trans_register(ret, &target_eventfd_trans);
+ }
break;
#endif
#if defined(TARGET_NR_eventfd2)
@@ -11930,7 +11936,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
host_flags |= O_CLOEXEC;
}
ret = get_errno(eventfd(arg1, host_flags));
- fd_trans_register(ret, &target_eventfd_trans);
+ if (ret >= 0) {
+ fd_trans_register(ret, &target_eventfd_trans);
+ }
break;
}
#endif
--
2.11.0
- [Qemu-devel] [PULL 10/25] qcow2: fix null pointer dereference, (continued)
- [Qemu-devel] [PULL 10/25] qcow2: fix null pointer dereference, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 09/25] ivshmem: fix incorrect error handling in ivshmem_recv_msg(), Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 02/25] fix qemu-system-unicore32 crashing when calling without -kernel, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 12/25] net/eth: fix incorrect check of iov_to_buf() return value, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 08/25] loader: check get_image_size() return value, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 04/25] tests: test-netfilter && pxe-test require slirp, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 16/25] syscall: fix use of uninitialized values, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 13/25] m68k/translate: fix incorrect copy/paste, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 19/25] docs: fix broken paths to docs/interop dir, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 18/25] thunk: assert nb_fields is valid, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 17/25] syscall: check inotify() and eventfd() return value,
Michael Tokarev <=
- [Qemu-devel] [PULL 20/25] docs: fix broken paths to docs/interop/qcow2.txt, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 22/25] docs: fix broken paths to docs/devel/atomics.txt, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 11/25] ui/vnc: fix leak of SocketAddress **, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 21/25] docs: fix broken paths to docs/devel/qapi-code-gen.txt, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 03/25] MAINTAINERS: Improve the NetBSD regex pattern, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 15/25] syscall: fix dereference of undefined pointer, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 01/25] tests: check-qom-proplist: fix leak, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 05/25] build-sys: there is no qemu-ga.c, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 25/25] docs: fix broken paths to docs/specs/ivshmem-spec.txt, Michael Tokarev, 2017/07/31