[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI |
Date: |
Mon, 31 Jul 2017 16:30:13 +0300 |
> From: Markus Armbruster [mailto:address@hidden
> "Pavel Dovgalyuk" <address@hidden> writes:
>
> >> From: Markus Armbruster [mailto:address@hidden
> >> ReplayMode is defined in the QAPI schema, but not used there. Of the
> >> stuff QAPI generates for it only the typedef is actually used. Use of
> >> QAPI is pointless and only complicates things, so don't.
> >
> > This a bit useless now, but we plan to add more patches that include
> > QAPI commands for controlling and inspecting the record/replay process.
>
> I assume YAGNI until proven otherwise.
>
> Posting patches putting ReplayMode to use could serve as proof.
This is a sample of not yet included patch.
https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg04278.html
Pavel Dovgalyuk
Re: [Qemu-devel] [PATCH 0/3] Don't QAPI without need, Eric Blake, 2017/07/28