[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] trace-events: print 0x before hex number
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/4] trace-events: print 0x before hex numbers |
Date: |
Mon, 31 Jul 2017 09:25:03 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v3 0/4] trace-events: print 0x before hex numbers
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d9245be7be trace-events: fix code style: print 0x before hex numbers
4c4e26430d checkpatch: check trace-events code style
811ef299fd trace-events: fix code style: %# -> 0x%
b908ad1263 coding_style: add point about 0x in trace-events
=== OUTPUT BEGIN ===
Checking PATCH 1/4: coding_style: add point about 0x in trace-events...
Checking PATCH 2/4: trace-events: fix code style: %# -> 0x%...
Checking PATCH 3/4: checkpatch: check trace-events code style...
WARNING: line over 80 characters
#26: FILE: scripts/checkpatch.pl:1343:
+ ERROR("Don't use '#' flag of printf format
('%#') in " .
ERROR: line over 90 characters
#27: FILE: scripts/checkpatch.pl:1344:
+ "trace-events, use '0x' prefix instead\n"
. $herecurr);
ERROR: line over 90 characters
#30: FILE: scripts/checkpatch.pl:1347:
+ qr/%[-+
*.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
ERROR: line over 90 characters
#32: FILE: scripts/checkpatch.pl:1349:
+ # don't consider groups splitted by [.:/ ],
like 2A.20:12ab
WARNING: line over 80 characters
#33: FILE: scripts/checkpatch.pl:1350:
+ my $tmpline = $rawline =~ s/($hex[.:\/
])+$hex//gr;
WARNING: line over 80 characters
#36: FILE: scripts/checkpatch.pl:1353:
+ ERROR("Hex numbers must be prefixed
with '0x'\n" .
total: 3 errors, 3 warnings, 25 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: trace-events: fix code style: print 0x before hex numbers...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden