|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 02/15] target/arm: Don't trap WFI/WFE for M profile |
Date: | Thu, 3 Aug 2017 13:28:28 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/02/2017 09:43 AM, Peter Maydell wrote: > M profile cores can never trap on WFI or WFE instructions. Check for > M profile in check_wfx_trap() to ensure this. > > The existing code will do the right thing for v7M cores because > the hcr_el2 and scr_el3 registers will be all-zeroes and so we > won't attempt to trap, but when we start setting ARM_FEATURE_V8 > for v8M cores the v8A handling of SCTLR.nTWE and .nTWI will not > give the right results. > > Signed-off-by: Peter Maydell <address@hidden> > --- > target/arm/op_helper.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Richard Henderson <address@hidden> While looking at this, I think there's an error in helper_wfi. The early exit for cpu_has_work should happen after the exception check. r~
[Prev in Thread] | Current Thread | [Next in Thread] |