[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 23/29] migration: new cmd MIG_CMD_POSTCOPY_RESUME
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [RFC 23/29] migration: new cmd MIG_CMD_POSTCOPY_RESUME |
|
Date: |
Fri, 4 Aug 2017 15:04:19 +0800 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Aug 03, 2017 at 12:05:41PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > +static int loadvm_postcopy_handle_resume(MigrationIncomingState *mis)
> > +{
> > + /*
> > + * This means source VM is ready to resume the postcopy migration.
> > + * It's time to switch state and release the fault thread to
> > + * continue service page faults.
> > + */
> > + migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_RECOVER,
> > + MIGRATION_STATUS_POSTCOPY_ACTIVE);
> > + qemu_sem_post(&mis->postcopy_pause_sem_fault);
>
> Is it worth sanity checking that you were in RECOVER at this point?
Yeah, it never hurts. Will do.
--
Peter Xu