[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Clarify about relative b
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Clarify about relative backing file options |
Date: |
Fri, 4 Aug 2017 09:23:21 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/04/2017 08:55 AM, Fam Zheng wrote:
> It's not too surprising when a user specifies the backing file relative
> to the current working directory instead of the top layer image. This
> causes error when they differ. Though the error message has enough
> information to infer the fact about the misunderstanding, it is better
> if we document this explicitly, so that users don't have to learn from
> mistakes.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> qemu-img.texi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index 72dabd6b3e..cf079f90e2 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -244,6 +244,9 @@ only the differences from @var{backing_file}. No size
> needs to be specified in
> this case. @var{backing_file} will never be modified unless you use the
> @code{commit} monitor command (or qemu-img commit).
>
> +If a relative path name is given, the backing file is looked up against
> address@hidden, rather than the current working directory.
Maybe better as:
the backing file is looked up relative to the directory containing
@var{filename}
In all three places
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature