[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11 22/23] tcg/ppc: Look for shifted consta
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11 22/23] tcg/ppc: Look for shifted constants |
Date: |
Fri, 4 Aug 2017 09:58:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/04/2017 09:39 AM, Philippe Mathieu-Daudé wrote:
>> @@ -638,6 +639,14 @@ static void tcg_out_movi_int(TCGContext *s, TCGType
>> type, TCGReg ret,
>> return;
>> }
>> + lsb = ctz64(arg);
>> + high = arg >> lsb;
>> + if (arg == (int16_t)arg) {
>
> Can you move these here?
>
> + lsb = ctz64(arg);
> + high = arg >> lsb;
No, because you've found a bug -- the if should be testing high, not arg. ;-)
Thanks,
r~
- [Qemu-devel] [PATCH for-2.11 16/23] tcg/arm: Tighten tlb indexing offset test, (continued)
- [Qemu-devel] [PATCH for-2.11 16/23] tcg/arm: Tighten tlb indexing offset test, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 09/23] tcg/s390: Use constant pool for ori, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 15/23] tcg/arm: Improve tlb load for armv7, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 14/23] tcg/sparc: Use constant pool for movi, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 20/23] tcg/arm: Use constant pool for call, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 18/23] tcg/arm: Extract INSN_NOP, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 19/23] tcg/arm: Use constant pool for movi, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 17/23] tcg/arm: Code rearrangement, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 22/23] tcg/ppc: Look for shifted constants, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 21/23] tcg/ppc: Change TCG_REG_RA to TCG_REG_TB, Richard Henderson, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 23/23] tcg/ppc: Use constant pool for movi, Richard Henderson, 2017/08/04