[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.10 v3 1/6] docker: ensure NOUSER for travi
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH for 2.10 v3 1/6] docker: ensure NOUSER for travis images |
Date: |
Tue, 08 Aug 2017 09:55:20 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.50.3 |
Fam Zheng <address@hidden> writes:
> On Mon, 08/07 16:39, Alex Bennée wrote:
>> While adding the current user is a useful default behaviour for
>> creating new images it is not appropriate for Travis which already has
>> a default user.
>
> Target address@hidden will not have NOUSER=1 automatically, right? Is that
> a problem?
It doesn't until this patch. In fact it would be better if we ran travis
tests with the travis user rather than the mapped local user.
>
> Fam
>
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> tests/docker/Makefile.include | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
>> index aaab1a4208..d7dafdbd27 100644
>> --- a/tests/docker/Makefile.include
>> +++ b/tests/docker/Makefile.include
>> @@ -71,6 +71,7 @@ docker-image-debian-ppc64el-cross: docker-image-debian9
>> docker-image-debian-s390x-cross: docker-image-debian9
>> docker-image-debian-win32-cross: docker-image-debian8-mxe
>> docker-image-debian-win64-cross: docker-image-debian8-mxe
>> +docker-image-travis: NOUSER=1
>>
>> # Expand all the pre-requistes for each docker image and test combination
>> $(foreach i,$(DOCKER_IMAGES), \
>> --
>> 2.13.0
>>
>>
--
Alex Bennée
- [Qemu-devel] [PATCH for 2.10 v3 0/6] Various docker fixes, Alex Bennée, 2017/08/07
- [Qemu-devel] [PATCH for 2.10 v3 1/6] docker: ensure NOUSER for travis images, Alex Bennée, 2017/08/07
- [Qemu-devel] [PATCH for 2.10 v3 2/6] docker: fix dirty/stash detection on some systems, Alex Bennée, 2017/08/07
- [Qemu-devel] [PATCH for 2.10 v3 3/6] docker: ignore submodules when checking diff, Alex Bennée, 2017/08/07
- [Qemu-devel] [PATCH for 2.10 v3 5/6] docker: don't install device-tree-compiler build-deps in travis.docker, Alex Bennée, 2017/08/07
- [Qemu-devel] [PATCH for 2.10 v3 4/6] docker: docker.py make --no-cache skip checksum test, Alex Bennée, 2017/08/07
- [Qemu-devel] [PATCH for 2.10 v3 6/6] docker: reduce noise when building travis.docker, Alex Bennée, 2017/08/07