Re: [Qemu-devel] [PATCH v4 4/7] block: convert ThrottleGroup to object with QOM

[Alberto Garcia]

On Wed 09 Aug 2017 12:07:31 PM CEST, Manos Pitsidianakis wrote:
> +    /* unfix buckets to check validity */
> +    throttle_get_config(&tg->ts, cfg);
> +    if (!throttle_is_valid(cfg, errp)) {
> +        return;
> +    }
> +    /* fix buckets again */
> +    throttle_config(&tg->ts, tg->clock_type, cfg);

Ugh, this whole fix/unfix buckets should be transparent to outside users
of throttle.c.

You can leave this here for now but I'll think of a way to eliminate the
need to do this.

Berto