[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target |
Date: |
Tue, 15 Aug 2017 07:02:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 14.08.2017 22:44, Eric Farman wrote:
> How often does one really do a "make clean" ? Rather infrequently,
> as I only stumbled on this today.
>
> Perhaps I have missed the RM variable somewhere, as I see similar syntax
> in some of the tests/tcg/ Makefiles, but I don't see it being set here.
> My configure statement isn't terribly interesting, just enabling debug
> for an s390x target, and as such there's no RM variable in its output.
> I'll trust that Thomas will chime in with where it should have been.
> In the meantime, this does the trick for me.
RM is one of the variables that should be pre-initialized by Make, and
AFAIK should be used to increase portability (well, it's likely not
important for QEMU since we require a posix-shell like built environment
anyway).
According to the info page of Make, chapter "10.3 Variables Used by
Implicit Rules":
`RM'
Command to remove a file; default `rm -f'.
I've also checked it again and "make clean" works fine here (using GNU
Make 3.82). Which version of Make (and Linux distro) are you using?
Anyway, maybe I also simply missed something, so I'm certainly also fine
with the patch to revert it to "rm -f".
Thomas
Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target, Peter Maydell, 2017/08/15