[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target |
Date: |
Tue, 15 Aug 2017 10:39:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 15.08.2017 10:32, Cornelia Huck wrote:
> On Tue, 15 Aug 2017 10:26:18 +0200
> Thomas Huth <address@hidden> wrote:
[...]
>> The parameter -R disables the built-in variables, so RM can indeed not
>> work here. Sorry, I wasn't aware of that setting yet, so your patch is
>> indeed the right fix here (or we should maybe define RM in rules.mak, too).
>
> The other users are all in tests/tcg/.
>
> Would there be value in using the built-in variables generally? (Well,
> value that outweighs having to go through the qemu build system...)
There are some non-posix shells where "rm -f" does not work (e.g.
COMMAND.COM on Windows), and this is where $(RM) is really useful. But
since we require a posix-style built environment anyway, it's not that
important for the QEMU build system. OTOH, $(RM) is a standard Make
variable, so other people might step into this trap as well - so it's
maybe better to define it in rules.mak to avoid future confusion?
Thomas
Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target, Peter Maydell, 2017/08/15