Re: [Qemu-devel] [PATCH for-2.10 v2 1/2] trace: use static event ID mapping in simpletrace.stp

[Daniel P. Berrange]

On Tue, Aug 15, 2017 at 09:44:29AM +0100, Stefan Hajnoczi wrote:
> This is a partial revert of commit
> 7f1b588f20d027730676e627713ae3bbf6baab04 ("trace: emit name <-> ID
> mapping in simpletrace header"), which broke the SystemTap flight
> recorder because event mapping records may not be present in the ring
> buffer when the trace is analyzed.  This means simpletrace.py
> --no-header does not know the event ID mapping needed to pretty-print
> the trace.
> 
> Instead of numbering events dynamically, use a static event ID mapping
> as dictated by the event order in the trace-events-all file.
> 
> The simpletrace.py script also uses trace-events-all so the next patch
> will fix the simpletrace.py --no-header option to take advantage of this
> knowledge.
> 
> Cc: Daniel P. Berrange <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  scripts/tracetool/format/simpletrace_stap.py | 31 
> ++--------------------------
>  1 file changed, 2 insertions(+), 29 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|