qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h
Date: Thu, 17 Aug 2017 14:41:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 17.08.2017 11:22, David Hildenbrand wrote:
> Let's reshuffle the function prototypes so we get a cleaner outline
> of the files.
> 
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/cpu.h | 140 
> ++++++++++++++++++++++++++---------------------------
>  1 file changed, 69 insertions(+), 71 deletions(-)

Not sure whether this code churn here is really worth the effort ... I'd
prefer to introduce file-specific headers for the prototypes instead,
e.g. helper.h, mmu_helper.h, etc. ... but that's just my 0.02 € ... I
also won't object if this patch gets included as is.

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]