Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

[Philippe Mathieu-Daudé]

On 08/17/2017 02:55 PM, Alistair Francis wrote:
> > > On 15/08/2017 09:30, Markus Armbruster wrote:
> > > > The stupid fix is to repeat libraries until the link succeeds:
> > > >
> > > >      test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a
[...]
> > > > Sticking '-Wp,-(' and '-Wp,-)' into the command line I get from make V=1
> > > > doesn't work for me, though.
> > > >
> > > > The smart solution is not to have .a reference each other.
> > >
> > > Nah, I think we should teach those new kids on the block about -lX11
> > > instead. :)
>
> This sounds scary...
>
> > > > Paolo, what do you think?
> > >
> > > Another possibility is to just merge the two static libraries into one.
> >
> > Sounds good to me!
>
> I feel like I have opened a can of worms.

you are good at it! IIRC it all started with a 1-line change in 
tcp_chr_wait_connected() more than 2 months ago :)

> I can try and combine libqemustub.a into libqemuutil.a is that the
> solution? I just want to make sure before I start this.

IMHO your series is OK like this, add a "TODO remove once libqemuutil.a 
circular dep is resolved" comment in the Makefile is enough, and let 
this issue for another time.

Regards,

Phil.