[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] s390x/tcg: specification exception for u
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] s390x/tcg: specification exception for unknown diag |
|
Date: |
Fri, 18 Aug 2017 13:51:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 18.08.2017 13:48, Cornelia Huck wrote:
> While the PoP is silent on the issue, z/VM documentation states
> that unknown diagnose codes trigger a specification exception.
> We already do that when running with kvm, so change tcg to do so
> as well.
>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> target/s390x/misc_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
> index d23ffcd890..5a1eba02ab 100644
> --- a/target/s390x/misc_helper.c
> +++ b/target/s390x/misc_helper.c
> @@ -109,7 +109,7 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1,
> uint32_t r3, uint32_t num)
> }
>
> if (r) {
> - program_interrupt(env, PGM_OPERATION, ILEN_AUTO);
> + program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO);
> }
> }
Reviewed-by: Thomas Huth <address@hidden>