[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before fi
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before first launch() |
Date: |
Fri, 18 Aug 2017 19:05:16 +0200 |
is_running() returns None when called before the first time we
call launch():
>>> import qemu
>>> vm = qemu.QEMUMachine('qemu-system-x86_64')
>>> vm.is_running()
>>>
It should return False instead. This patch fixes that.
For consistence, this patch removes the parenthesis from the
second clause as it's not really needed.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 880e3e8219..0ae5d39414 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -86,7 +86,7 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen and (self._popen.returncode is None)
+ return self._popen is not None and self._popen.returncode is None
def exitcode(self):
if self._popen is None:
--
2.13.5
- Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr, (continued)
[Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 11/11] qemu.py: refactor launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 08/11] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before first launch(),
Amador Pahim <=
[Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null, Amador Pahim, 2017/08/18
Re: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups, Eduardo Habkost, 2017/08/31