[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 5/6] hmp: support "without_bql"
From: |
Peter Xu |
Subject: |
[Qemu-devel] [RFC 5/6] hmp: support "without_bql" |
Date: |
Mon, 21 Aug 2017 15:44:23 +0800 |
Introducing new option "without_bql" for HMP commands. It works just
like QMP "without-bql", but for HMP commands.
Signed-off-by: Peter Xu <address@hidden>
---
monitor.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/monitor.c b/monitor.c
index 18504ef..475a3a6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -124,6 +124,8 @@ typedef struct mon_cmd_t {
const char *args_type;
const char *params;
const char *help;
+ /* Whether this command can be run without taking BQL? */
+ bool without_bql;
void (*cmd)(Monitor *mon, const QDict *qdict);
/* @sub_table is a list of 2nd level of commands. If it does not exist,
* cmd should be used. If it exists, sub_table[?].cmd should be
@@ -3146,6 +3148,14 @@ static void handle_hmp_command(Monitor *mon, const char
*cmdline)
return;
}
+ if (cmd->without_bql) {
+ /*
+ * This is similar to QMP's "without-bql". See comments in
+ * do_qmp_dispatch().
+ */
+ take_bql = false;
+ }
+
if (take_bql) {
qemu_mutex_lock_iothread();
}
--
2.7.4
- [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread, Peter Xu, 2017/08/21
- [Qemu-devel] [RFC 3/6] QAPI: new QMP command option "without-bql", Peter Xu, 2017/08/21
- [Qemu-devel] [RFC 2/6] monitor: allow monitor to create thread to poll, Peter Xu, 2017/08/21
- [Qemu-devel] [RFC 4/6] migration: qmp: migrate_incoming don't need BQL, Peter Xu, 2017/08/21
- [Qemu-devel] [RFC 5/6] hmp: support "without_bql",
Peter Xu <=
- [Qemu-devel] [RFC 6/6] migration: hmp: migrate_incoming don't need BQL, Peter Xu, 2017/08/21
- [Qemu-devel] [RFC 1/6] monitor: move skip_flush into monitor_data_init, Peter Xu, 2017/08/21
- Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread, Fam Zheng, 2017/08/21
- Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread, Fam Zheng, 2017/08/21
- Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread, Dr. David Alan Gilbert, 2017/08/21
- Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread, Fam Zheng, 2017/08/21