[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of syse
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files |
Date: |
Mon, 21 Aug 2017 11:52:58 +0200 |
On Fri, 18 Aug 2017 19:28:34 +0200
David Hildenbrand <address@hidden> wrote:
> On 18.08.2017 18:08, Thomas Huth wrote:
> > On 18.08.2017 13:43, David Hildenbrand wrote:
> >> s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h.
> >
> > Why not simply #include "exec/cpu-all.h" ? If cpu.h is not really needed
> > here...
> >
> > Thomas
> >
> >
>
> Git grep showed me that this is a very rare thing to do, so I went for
> cpu.h. If you prefer cpu-all.h, I can use that.
Is there any target that does not include cpu-all.h in its cpu.h? We
probably can remove all includes of cpu-all.h in .c files, as all of
them include cpu.h as well...
- Re: [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed(), (continued)
[Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h, David Hildenbrand, 2017/08/18
Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h, Cornelia Huck, 2017/08/21
[Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, David Hildenbrand, 2017/08/18