[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes |
Date: |
Mon, 21 Aug 2017 17:51:19 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/18/2017 10:26 AM, Lukáš Doktor wrote:
> Hello guys,
>
> I'm reading the available python modules to exercise qemu and while reading
> them
> I fixed some issues that caught my attention. It usually starts with a simple
> pylint/docstring fixes and slowly graduates to more controversial ones so I'm
> open to suggestion to remove some of them.
>
> Kind regards,
> Lukáš
>
> Changes in v2
> - Squashed 2nd and 10th patches into 2nd one
> - Use repr() in MonitorResponseError's description
> - Improved commit message of the 6th patch
> - Two tweaks to docstrings changed in the 6th patch
> - Also updated qmp-shell to use new-style super calls (7th patch)
> - Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch)
> - Changed the style of the style-fix in the 10th commit
>
> Changes in v3
> - Don't use repr in the 5th patch in MonitorResponseError
>
> Changes in v4
> - Use correct git base (remove unwanted commits)
>
> Changes in v5
> - Avoid bool comparison
> - Change report to return in one docstring
> - Removed the unnecessary spaces around single-line docstring
>
> Changes in v6
> - Bunch of docstring tweaks by Markus Armbruster
> - Line break in <80 chars
> - result dict => response dict
> - Removed the "event_match" rename
>
Looks like all ten patches have an R-B despite changes; but it looks
like nothing particularly major was changed anyway.
Does this fall under Markus's jurisdiction?
(Well, except for qtest.py which seemingly has double-extra-no
maintainer...!)
--js
- [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys(), (continued)
- [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys(), Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 04/10] qemu.py: Simplify QMP key-conversion, Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 05/10] qemu.py: Use custom exceptions rather than Exception, Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 06/10] qmp.py: Couple of pylint/style fixes, Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol, Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 08/10] qmp.py: Avoid "has_key" usage, Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 09/10] qmp.py: Avoid overriding a builtin object, Lukáš Doktor, 2017/08/18
- [Qemu-devel] [PATCH v6 10/10] qtest.py: Few pylint/style fixes, Lukáš Doktor, 2017/08/18
- Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes,
John Snow <=
- Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes, Paolo Bonzini, 2017/08/22
- Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes, John Snow, 2017/08/22
- Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes, Eduardo Habkost, 2017/08/22
Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes, Eduardo Habkost, 2017/08/30