[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

From: BALATON Zoltan
Subject: Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller
Date: Tue, 22 Aug 2017 23:54:23 +0200 (CEST)
User-agent: Alpine 2.21 (BSF 202 2017-01-01)

On Tue, 22 Aug 2017, John Snow wrote:
On 08/22/2017 04:15 PM, BALATON Zoltan wrote:
On Tue, 22 Aug 2017, John Snow wrote:
On 08/22/2017 07:08 AM, BALATON Zoltan wrote:
On Mon, 21 Aug 2017, John Snow wrote:

Sure, but be advised that if the device causes problems outside of this
use case and there's nobody willing or able to review it, that it may
get removed again.

I don't have a lot of free time to go through the register list point by
point and make sure this is implemented correctly either, but if this
helps your work I'm OK not holding it up.

No problem, of course if a bug is reported I'll try to fix it or if I
can't it's OK to remove it again. I just hope it gets more testing and
maybe others could contribute fixes if it's in the main line.

Yep, just a "warning"!

Thanks, it looks sane enough to me in general, If you have instructions
for installing and testing a machine using this advice I'd like to check
it out later this week and I'll sign off on the re-spin.

I'll probably won't have time to send an updated version before the end of the week but since the modifications requested are about DPRINTFs and comments (nothing changing functionality) at this point, you could test this version if you'll have time.

Since this card is a generic PCI device and not specific to the machine my series aims to emulate, I think it could be tested alone in any other machine such as pc or some other emulated machine. Linux has a driver (sata_sil I think) and a lot of other OSes too so if you can try adding this device with an ide-hd and an ide-cd and install any of these OSes this could verify if it's working or could uncover some bugs. I don't know a better test now because of the bugs in the Sam460ex that prevents it from working reliably at the moment.

Thank you for your support.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]