Re: [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

[Marc-André Lureau]

Hi

On Thu, Aug 24, 2017 at 9:39 PM Dr. David Alan Gilbert (git) <
address@hidden> wrote:

> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Add a vu_queue_started method to complement vu_queue_enabled.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>

Reviewed-by: Marc-André Lureau <address@hidden>



> ---
>  contrib/libvhost-user/libvhost-user.c | 6 ++++++
>  contrib/libvhost-user/libvhost-user.h | 9 +++++++++
>  2 files changed, 15 insertions(+)
>
> diff --git a/contrib/libvhost-user/libvhost-user.c
> b/contrib/libvhost-user/libvhost-user.c
> index 35fa0c5e56..201b9846e9 100644
> --- a/contrib/libvhost-user/libvhost-user.c
> +++ b/contrib/libvhost-user/libvhost-user.c
> @@ -930,6 +930,12 @@ vu_queue_enabled(VuDev *dev, VuVirtq *vq)
>      return vq->enable;
>  }
>
> +bool
> +vu_queue_started(VuDev *dev, VuVirtq *vq)
>

I guess we could make it const, but this is true for many other functions.
Could be done later in one go.

> +{
> +    return vq->started;
> +}
> +
>  static inline uint16_t
>  vring_avail_flags(VuVirtq *vq)
>  {
> diff --git a/contrib/libvhost-user/libvhost-user.h
> b/contrib/libvhost-user/libvhost-user.h
> index 53ef222c0b..acd019876d 100644
> --- a/contrib/libvhost-user/libvhost-user.h
> +++ b/contrib/libvhost-user/libvhost-user.h
> @@ -328,6 +328,15 @@ void vu_queue_set_notification(VuDev *dev, VuVirtq
> *vq, int enable);
>  bool vu_queue_enabled(VuDev *dev, VuVirtq *vq);
>
>  /**
> + * vu_queue_started:
> + * @dev: a VuDev context
> + * @vq: a VuVirtq queue
> + *
> + * Returns: whether the queue is started.
> + */
> +bool vu_queue_started(VuDev *dev, VuVirtq *vq);
> +
> +/**
>   * vu_queue_empty:
>   * @dev: a VuDev context
>   * @vq: a VuVirtq queue
> --
> 2.13.5
>
>
> --
Marc-André Lureau