Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  include/qapi/qmp/qlit.h | 2 +-
>  qobject/qlit.c          | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
> index 2e22d0f73c..8882016199 100644
> --- a/include/qapi/qmp/qlit.h
> +++ b/include/qapi/qmp/qlit.h
> @@ -44,6 +44,6 @@ struct QLitDictEntry {
>  #define QLIT_QLIST(val) \
>      { .type = QTYPE_QLIST, .value.qlist = (val) }
>  
> -bool qlit_equal_qobject(QLitObject *lhs, QObject *rhs);
> +bool qlit_equal_qobject(const QLitObject *lhs, const QObject *rhs);
>  
>  #endif /* QLIT_H_ */
> diff --git a/qobject/qlit.c b/qobject/qlit.c
> index a2975bef3f..ae2787ef35 100644
> --- a/qobject/qlit.c
> +++ b/qobject/qlit.c
> @@ -41,7 +41,7 @@ static void compare_helper(QObject *obj, void *opaque)
>          qlit_equal_qobject(&helper->objs[helper->index++], obj);
>  }
>  
> -bool qlit_equal_qobject(QLitObject *lhs, QObject *rhs)
> +bool qlit_equal_qobject(const QLitObject *lhs, const QObject *rhs)
>  {
>      int64_t val;

Could be squashed into the previous patch, but since you got the two
split, let's leave them split and save us the trouble of wording the
squash's commit message.

Reviewed-by: Markus Armbruster <address@hidden>