[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filte
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver |
Date: |
Fri, 25 Aug 2017 12:05:10 +0100 |
On Thu, Aug 24, 2017 at 10:15 PM, Manos Pitsidianakis
<address@hidden> wrote:
> On Thu, Aug 24, 2017 at 07:43:08PM +0100, Stefan Hajnoczi wrote:
>>
>> On Tue, Aug 22, 2017 at 01:15:35PM +0300, Manos Pitsidianakis wrote:
>>>
>>> +_supported_fmt qcow2
>>
>>
>> What makes this test qcow2-specific? With additional filtering for
>> IMGFMT it should be possible to run this on any image format.
>
>
> I think none of the available filters hide all of the image details in
> query-block and company. _filter_imgfmt hides the image extensions but not
> the image specific fields (eg virtual-size, actual-size and
> format-specific). Perhaps a new filter that hides everything but "format"
> and "filename" in the "image" subdict can be introduced later.
It's a little cumbersome to filter JSON in shell. The filters do not
use jq(1) at the moment.
Tests written in Python have an easier time of filtering certain
fields. I did that recently for QMP Event objects in 194.
Anyway, it's okay to keep this test qcow2-only for now.
Stefan
- Re: [Qemu-devel] [PATCH v7 5/6] block: add throttle block filter driver, (continued)