[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length |
Date: |
Fri, 25 Aug 2017 10:16:10 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Aug 24, 2017 at 06:31:24PM +0200, Igor Mammedov wrote:
> since commit ( 9262685b cpu: Factor out cpu_generic_init() )
> features parsed by it were truncated only to the 1st feature
> after CPU name due to fact that
>
> featurestr = strtok(NULL, ",");
> cc->parse_features(cpu, featurestr, &err);
>
> would extract exactly one feature and parse_features() callback
> would parse it and only it leaving the rest of features ignored.
>
> Reuse approach from x86 custom impl. i.e. replace strtok() token
> parsing with g_strsplit(), which would split feature string in
> 2 parts name and features list and pass the later to
> parse_features() callback.
>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
- [Qemu-devel] [PATCH for-2.11 v3 00/25] complete cpu QOMification and remove cpu_FOO_init() helpers, Igor Mammedov, 2017/08/24
- [Qemu-devel] [PATCH for-2.11 v3 02/25] sparc: convert cpu models to SPARC cpu subclasses, Igor Mammedov, 2017/08/24
- [Qemu-devel] [PATCH for-2.11 v3 04/25] sparc: convert cpu features to qdev properties, Igor Mammedov, 2017/08/24
- [Qemu-devel] [PATCH for-2.11 v3 03/25] sparc: embed sparc_def_t into CPUSPARCState, Igor Mammedov, 2017/08/24
- [Qemu-devel] [PATCH for-2.11 v3 05/25] sparc: move adhoc CPUSPARCState initialization to realize time, Igor Mammedov, 2017/08/24
- [Qemu-devel] [PATCH for-2.11 v3 06/25] sparc: make cpu feature parsing property based, Igor Mammedov, 2017/08/24
- [Qemu-devel] [PATCH for-2.11 v3 07/25] sparc: replace cpu_sparc_init() with cpu_generic_init(), Igor Mammedov, 2017/08/24