[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_d
|
From: |
Gonglei (Arei) |
|
Subject: |
Re: [Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted() |
|
Date: |
Wed, 30 Aug 2017 00:33:53 +0000 |
> -----Original Message-----
> From: Eduardo Habkost [mailto:address@hidden
> Sent: Wednesday, August 30, 2017 6:04 AM
> To: address@hidden
> Cc: Gonglei (Arei); Paolo Bonzini; Igor Mammedov; Andreas Färber; Lin Ma
> Subject: [PATCH] qom: Remove unused errp parameter from can_be_deleted()
>
> The errp argument is ignored by all implementations of the
> method, and user_creatable_del() would break if any
> implementation set an error (because it calls error_setg(errp) if
> the function returns false). Remove the unused parameter.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> include/qom/object_interfaces.h | 5 ++---
> backends/cryptodev.c | 2 +-
> backends/hostmem.c | 2 +-
> qom/object_interfaces.c | 6 +++---
> 4 files changed, 7 insertions(+), 8 deletions(-)
>
Reviewed-by: Gonglei <address@hidden>