[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented c
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models |
Date: |
Wed, 30 Aug 2017 16:14:16 +0200 |
On Wed, 30 Aug 2017 15:46:30 +0200
Thomas Huth <address@hidden> wrote:
> On 30.08.2017 15:24, Igor Mammedov wrote:
> > Remove cpu models that aren't implemented and are not
> > compiled/tested since they are under TODO ifdef
> > which isn't defined in sources.
> >
> > If someone really needs a removed model he/she should add
> > as regular one with corresponding implementation.
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > target/ppc/cpu-models.c | 459
> > ------------------------------------------------
> > 1 file changed, 459 deletions(-)
> >
> > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> > index cf878a9..611fc1b 100644
> > --- a/target/ppc/cpu-models.c
> > +++ b/target/ppc/cpu-models.c
> > @@ -19,11 +19,6 @@
> > * License along with this library; if not, see
> > <http://www.gnu.org/licenses/>.
> > */
> [...]
> > /* PowerPC 440 family
> > */
> > -#if defined(TODO_USER_ONLY)
> > - POWERPC_DEF("440", CPU_POWERPC_440, 440GP,
> > - "Generic PowerPC 440")
> > -#endif
>
> Please don't remove this TODO_USER_ONLY entry. It's still used if the
> code is compiled with CONFIG_USER_ONLY.
oops, thanks for catching it.
it wasn't intentional, I'll send fixup
>
> Thomas
- [Qemu-devel] [PATCH v2 0/8] ppc: cpu_model handling cleanups, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 4/8] ppc: make cpu alias point only to real cpu models, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 2/8] ppc: use macros to make cpu type name from string literal, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 1/8] ppc: replace cpu_ppc_init() with cpu_generic_init(), Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 6/8] ppc: simplify cpu model lookup by PVR, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 5/8] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 7/8] ppc: drop caching ObjectClass from PowerPCCPUAlias, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 8/8] ppc: remove non implemented cpu models, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 3/8] ppc: make cpu_model translation to type consistent, Igor Mammedov, 2017/08/30